fix: (CDK) (BaseModelWithDeprecations) - filter the warnings to be shown, ignore the `SyntaxWarning` by bazarnov · Pull Request #535 · airbytehq/airbyte-python-cdk

Baz (bazarnov) · 2025-05-07T12:36:43Z

What

During the string interpolation the SyntaxWarning message is printed to stdout making the platform to think the RECORD is malformed; thus the record gets filtered out, causing record count mismatch.

How

added the warnings filtering, to filter out the SyntaxWarning being printed to stdout
added the \n to the formatted message, to be able to ignore sudden warnings in the stdout by the platform

User Impact

No impact is expected.

Summary by CodeRabbit

Chores
- Suppressed display of all SyntaxWarning messages globally.
- Adjusted formatting of warning messages for improved readability.

Copilot

Pull Request Overview

This pull request updates the BaseModelWithDeprecations to filter out SyntaxWarning messages from the Airbyte log output.

Added a filter to ignore SyntaxWarning messages during string evaluation
Updated the warning configuration in base_model_with_deprecations.py

coderabbitai · 2025-05-07T12:38:48Z

📝 Walkthrough

Walkthrough

A global filter was added to suppress all SyntaxWarning warnings using the warnings module in the base_model_with_deprecations.py file. This suppression occurs immediately after customizing the warning message format by appending a newline character. No other logic, error handling, or control flow in the file was changed.

Changes

File(s)	Summary of Changes
airbyte_cdk/sources/declarative/models/base_model_with_deprecations.py	Added a global filter to ignore all `SyntaxWarning` warnings after customizing the warning message format to include a trailing newline. No other logic or exports were altered.

Suggested reviewers

lmossman

Would you like to consider adding a comment in the code to clarify why SyntaxWarning is being suppressed globally, just in case future maintainers are curious? Wdyt?

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96ae2dc and 34c0f1c.

📒 Files selected for processing (1)

airbyte_cdk/sources/declarative/models/base_model_with_deprecations.py (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

airbyte_cdk/sources/declarative/models/base_model_with_deprecations.py

⏰ Context from checks skipped due to timeout of 90000ms (9)

GitHub Check: Check: 'source-pokeapi' (skip=false)
GitHub Check: Check: 'source-amplitude' (skip=false)
GitHub Check: Check: 'source-shopify' (skip=false)
GitHub Check: Check: 'source-hardcoded-records' (skip=false)
GitHub Check: Pytest (All, Python 3.11, Ubuntu)
GitHub Check: Pytest (Fast)
GitHub Check: Pytest (All, Python 3.10, Ubuntu)
GitHub Check: SDM Docker Image Build
GitHub Check: Analyze (python)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

airbyte_cdk/sources/declarative/models/base_model_with_deprecations.py (1)

17-17: Clarify the intent of this comment for future maintainers.
The comment above the filter could mention which string‐evaluation path triggers the SyntaxWarning, so that it’s clear why this filter exists. Would adding that detail help? wdyt?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a81b3b and 96ae2dc.

📒 Files selected for processing (1)

airbyte_cdk/sources/declarative/models/base_model_with_deprecations.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (10)

GitHub Check: Check: 'source-pokeapi' (skip=false)
GitHub Check: Check: 'source-amplitude' (skip=false)
GitHub Check: Check: 'source-shopify' (skip=false)
GitHub Check: Check: 'source-hardcoded-records' (skip=false)
GitHub Check: Pytest (All, Python 3.11, Ubuntu)
GitHub Check: Pytest (All, Python 3.10, Ubuntu)
GitHub Check: SDM Docker Image Build
GitHub Check: Pytest (Fast)
GitHub Check: preview_docs
GitHub Check: Analyze (python)

Maxime Carbonneau-Leclerc (maxi297)

Approving considering we will do more research on this

fix

96ae2dc

Baz (bazarnov) self-assigned this May 7, 2025

Copilot AI review requested due to automatic review settings May 7, 2025 12:36

Baz (bazarnov) added the airbyte-python-cdk label May 7, 2025

github-actions bot added bug Something isn't working security labels May 7, 2025

Copilot AI reviewed May 7, 2025

View reviewed changes

Comment thread airbyte_cdk/sources/declarative/models/base_model_with_deprecations.py Outdated

Maxime Carbonneau-Leclerc (maxi297) reviewed May 7, 2025

View reviewed changes

Comment thread airbyte_cdk/sources/declarative/models/base_model_with_deprecations.py Outdated

coderabbitai bot requested changes May 7, 2025

View reviewed changes

Comment thread airbyte_cdk/sources/declarative/models/base_model_with_deprecations.py Outdated

coderabbitai bot approved these changes May 7, 2025

View reviewed changes

Maxime Carbonneau-Leclerc (maxi297) approved these changes May 7, 2025

View reviewed changes

added a new line for formatted message

34c0f1c

Aldo Gonzalez (aldogonzalez8) temporarily deployed to PyPi May 7, 2025 13:58 — with GitHub Actions Inactive

Aldo Gonzalez (aldogonzalez8) temporarily deployed to DockerHub May 7, 2025 13:58 — with GitHub Actions Inactive

Baz (bazarnov) merged commit aabf242 into main May 7, 2025
31 of 33 checks passed

Baz (bazarnov) deleted the baz/cdk/fix-syntax-warning-printed-to-stdout branch May 7, 2025 14:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: (CDK) (BaseModelWithDeprecations) - filter the warnings to be shown, ignore the `SyntaxWarning`#535

fix: (CDK) (BaseModelWithDeprecations) - filter the warnings to be shown, ignore the `SyntaxWarning`#535
Baz (bazarnov) merged 2 commits intomainfrom
baz/cdk/fix-syntax-warning-printed-to-stdout

Baz (bazarnov) commented May 7, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented May 7, 2025 •

edited

Loading

Walkthrough

Changes

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Maxime Carbonneau-Leclerc (maxi297) left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Baz (bazarnov) commented May 7, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

User Impact

Summary by CodeRabbit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Maxime Carbonneau-Leclerc (maxi297) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Baz (bazarnov) commented May 7, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)